On 31/03/2025 13:08, Henry Martin wrote: > When devm_kasprintf() fails, it returns a NULL pointer. However, this return value is not properly checked in the function exynos_generic_icc_probe. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > > A NULL check should be added after the devm_kasprintf() to prevent potential NULL pointer dereference error. > This is similar to the commit 050b23d081da. Not related. These are different drivers, so drop. These apply to all your patches. Best regards, Krzysztof
