On 23/03/2025 23:39, André Draszik wrote: > As a preparation for adding support for Samsung's S2MPG10, which is > connected via SPEEDY / ACPM rather than I2C, we're going to split out > (move) all I2C-specific driver code into its own kernel module, and > create a (common) core transport-agnostic kernel module. > > That move of code would highlight some unexpected alignment which > checkpatch would complain about. To avoid that, address the error now, > before the split, to keep the amount of unrelated changes to a minimum > when actually doing the split. > > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx> > --- > drivers/mfd/sec-core.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 83693686567df61b5e09f7129dc6b01d69156ff3..b931f66f366571d93ce59c301265fe1c9550b37d 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -276,10 +276,12 @@ sec_pmic_i2c_parse_dt_pdata(struct device *dev) > if (!pd) > return ERR_PTR(-ENOMEM); > > - pd->manual_poweroff = of_property_read_bool(dev->of_node, > - "samsung,s2mps11-acokb-ground"); > - pd->disable_wrstbi = of_property_read_bool(dev->of_node, > - "samsung,s2mps11-wrstbi-ground"); > + pd->manual_poweroff = > + of_property_read_bool(dev->of_node, > + "samsung,s2mps11-acokb-ground"); I don't think this code more readable. The continued line should be re-aligned. Best regards, Krzysztof
