On Fri, Mar 21, 2025 at 03:58:45PM +0200, Ivaylo Ivanov wrote: > description: > - eUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > + eUSB2 controller supports LS/FS/HS usb connectivity. > > properties: > compatible: > @@ -23,6 +23,7 @@ properties: > - qcom,x1e80100-snps-eusb2-phy > - const: qcom,sm8550-snps-eusb2-phy > - const: qcom,sm8550-snps-eusb2-phy > + - const: samsung,exynos2200-snps-eusb2-phy These two entries is just an enum. > > reg: > maxItems: 1 > @@ -31,12 +32,12 @@ properties: > const: 0 > > clocks: > - items: > - - description: ref > + minItems: 1 > + maxItems: 3 I am still not conviced that creating one schema for these devices brings benefits. If this is going to be one binding, then keep the list here with three items and add minItems, so the list is the same for all variants. > > clock-names: > - items: > - - const: ref > + minItems: 1 > + maxItems: 3 Keep the list here with three items and add minItems. > > resets: > maxItems: 1 > @@ -62,7 +63,52 @@ required: > - clock-names > - vdd-supply > - vdda12-supply > - - resets > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm8550-snps-eusb2-phy > + > + then: > + properties: > + reg: > + maxItems: 1 Not much improved, my comment is still valid. > + > + clocks: > + items: > + - description: ref maxItems: 1 > + > + clock-names: > + items: > + - const: ref maxItems: 1 > + > + required: > + - resets > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,exynos2200-snps-eusb2-phy > + > + then: > + properties: > + Drop blank line. and the clocks get here minItems: 3 Best regards, Krzysztof
