On Tue, Aug 12, 2025 at 04:44:15PM +0100, Lorenzo Stoakes wrote: > The coredump logic is slightly different from other users in that it both > stores mm flags and additionally sets and gets using masks. > > Since the MMF_DUMPABLE_* flags must remain as they are for uABI reasons, > and of course these are within the first 32-bits of the flags, it is > reasonable to provide access to these in the same fashion so this logic can > all still keep working as it has been. > > Therefore, introduce coredump-specific helpers __mm_flags_get_dumpable() > and __mm_flags_set_mask_dumpable() for this purpose, and update all core Why the double underscore here? Just looks a bit ugly so if we can avoid it I would but if not: Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>