On Mon, Sep 1, 2025 at 4:07 PM David Hildenbrand <david@xxxxxxxxxx> wrote: > > -static inline void assert_fault_locked(struct vm_fault *vmf) > > +static inline void assert_fault_locked(const struct vm_fault *vmf) > > { > > This confused me a bit: in the upper variant it's "*const" and here it's > "const *". That was indeed a mistake. Both should be "const*const". > There are multiple such cases here, which might imply that it is not > "relatively trivial to const-ify them". :) I double-checked this patch and couldn't find any other such mistake. Or do you mean the function vs prototype thing on parameter values?