Re: [PATCH] s390/nmi: Simplify return statement in nmi_registers_valid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 08, 2025 at 05:32:20PM +0200, Thorsten Blum wrote:
...
> @@ -321,9 +321,7 @@ static bool notrace nmi_registers_valid(union mci mci)
>  	cr2.reg = get_lowcore()->cregs_save_area[2];
>  	if (cr2.gse && !mci.gs && !test_cpu_flag(CIF_MCCK_GUEST))
>  		return false;
> -	if (!mci.ms || !mci.pm || !mci.ia)
> -		return false;
> -	return true;
> +	return mci.ms && mci.pm && mci.ia;
>  }
>  NOKPROBE_SYMBOL(nmi_registers_valid);

This change does not make the whole function readability better.

Thanks!




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux