Re: [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Heiko Carstens <hca@xxxxxxxxxxxxx>
Subject: Re: [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()
From: Thorsten Blum <thorsten.blum@xxxxxxxxx>
Date: Fri, 12 Sep 2025 12:09:43 +0200
Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20250912095620.10147A01-hca@linux.ibm.com>
References: <20250911214539.1483234-2-thorsten.blum@linux.dev> <20250912095620.10147A01-hca@linux.ibm.com>

On 12. Sep 2025, at 11:56, Heiko Carstens wrote:
> This is not an improvement and also incorrect, since kfree() may now
> be called with an error pointer.

Unless I'm missing something, kfree() works just fine with error
pointers. See linux/slab.h:

DEFINE_FREE(kfree, void *, if (!IS_ERR_OR_NULL(_T)) kfree(_T))

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()
  - From: Heiko Carstens
- Re: [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()
  - From: Thorsten Blum

References:
- [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()
  - From: Thorsten Blum
- Re: [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()
  - From: Heiko Carstens

Prev by Date: Re: next-20250912: riscv: s390: mm/kasan/shadow.c 'kasan_populate_vmalloc_pte' pgtable.h:247:41: error: statement with no effect [-Werror=unused-value]
Next by Date: Re: [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()
Previous by thread: Re: [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()
Next by thread: Re: [PATCH] s390/hypfs_sprp: Replace kzalloc() + copy_from_user() with memdup_user()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite Info] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Linux Media] [Device Mapper]