On 07.08.25 05:34, Dust Li wrote: > On 2025-08-06 17:41:06, Alexandra Winter wrote: >> Remove the __init marker because smc_core_init() is not the >> init function of the smc module and for consistency with >> smc_core_exit() which neither has an __exit marker. > Have you seen a real warning or error because of the __init marker ? > > I think the __init marker is just to tell the kernel this function > will only be called during initialization. So it doesn't need to > be the module's init function. > > Best regards, > Dust My bad. Thank you Dust, for pointing this out. This patch will be removed from the series.