On Wed, 2025-02-12 at 16:24 -0500, John B. Wyatt IV wrote:
> On Wed, Feb 12, 2025 at 02:53:35PM -0600, Crystal Wood wrote:
> > On Mon, 2025-02-10 at 14:50 -0500, John Kacur wrote:
> > > For the -s option, why do we need to put the IDLESTATEDISABLEDSTATUS, if
> > > we omit that can't we just get a result like running "cpupower idle-info"?
> > > Could you rename IDLESTATEDISABLEDSTATUS to just IDLESTATE_STATUS?
> >
> > This was confusing to me too, but it looks like the argument is actually
> > a particular idle state, not the status of that state. So it should be
> > "IDLESTATE" just like -d and -e. Or better, "IDLE-STATE" like "CPU-
> > LIST".
> >
> > -Crystal
> >
>
> Apologies for not answering you earlier John. Did not see this email until
> Crystal's email.
>
> If there is no objections I will go with Crystal's suggestion.
>
> Here is the current printout for the patch series I will send (note I changed
> a few items to address confusion). Please let me know if this addresses
> everyone's concerns:
>
> options:
> -h, --help show this help message and exit
> -i, --idle-info Print general idle information on cpus in CPU-LIST. If CPU-LIST is not specified, default to all cpus.
> -s IDLE-STATE, --status IDLE-STATE
> Print the idle-state (cpu sleep state) of the cpus in CPU-LIST as enabled or disabled. The argument is the index of the idle-state of the cpu as reported by -i. If
> CPU-LIST is not specified, default to all cpus.
> -d IDLE-STATE, --disable IDLE-STATE
> Disable cpus in CPU-LIST's idle-state (cpu sleep state). The argument is the index of the idle-state of the cpu as reported by -i. If CPU-LIST is not specified,
> default to all cpus.
> -e IDLE-STATE, --enable IDLE-STATE
> Enable cpus in CPU-LIST's idle-state (cpu sleep state). The argument is the index of the idle-state of the cpu as reported by -i. If CPU-LIST is not specified,
> default to all cpus.
We could simplify the description as:
-i, --idle-info Print general idle information for the selected CPUs,
including index values for IDLE-STATE.
-s IDLE-STATE, --status IDLE-STATE
Print whether IDLE-STATE is enabled on the selected
CPUs.
-d IDLE-STATE, --disable IDLE-STATE
Disable IDLE-STATE on the selected CPUs
-e IDLE-STATE, --enable IDLE-STATE
Enable IDLE-STATE on the selected CPUs
-c CPU-LIST, --cpus CPU-LIST
Specify the list of CPUs to act on. If omitted,
act on all CPUs.
-Crystal
