On Wed, Apr 30, 2025 at 08:13:08PM -0700, Dmitry Torokhov wrote: > Hi Wolfram, > > On Tue, Mar 18, 2025 at 10:17:41AM +0100, Wolfram Sang wrote: > > The I2C core now provides a debugfs entry for each client. Let this > > driver use it instead of the custom directory in debugfs root. Further > > improvements by this change: support of multiple instances. > > > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > --- > > > > Build tested only, by me and buildbots. Trying to cleanup the debugfs a > > little. But not sure if this is too complicated for users. Opinions? > > This looks nice and nobody is yelling. Any reason why I shouldn't simply > apply it? Not really. I marked this as RFC because the path changed from /sys/kernel/debug/edt_ft5x06 to /sys/kernel/debug/i2c/<i2c-bus>/<i2c-device>/ so people have to deal with bus and device numbers now. I usually think debugfs is mostly for developers, so they can handle that. I wasn't so sure with this driver for some reason...
Attachment:
signature.asc
Description: PGP signature