Hi Tomi,
Thank you for the patch.
On Fri, May 30, 2025 at 04:50:30PM +0300, Tomi Valkeinen wrote:
> Use the new version of v4l2_get_link_freq() which supports media_pad as
> a parameter.
The commit message should explain why. With that fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/renesas/rcar-csi2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/platform/renesas/rcar-csi2.c
> index 9979de4f6ef1..ddbdde23c122 100644
> --- a/drivers/media/platform/renesas/rcar-csi2.c
> +++ b/drivers/media/platform/renesas/rcar-csi2.c
> @@ -954,6 +954,7 @@ static int rcsi2_set_phypll(struct rcar_csi2 *priv, unsigned int mbps)
> static int rcsi2_calc_mbps(struct rcar_csi2 *priv, unsigned int bpp,
> unsigned int lanes)
> {
> + struct media_pad *remote_pad;
> struct v4l2_subdev *source;
> s64 freq;
> u64 mbps;
> @@ -962,8 +963,9 @@ static int rcsi2_calc_mbps(struct rcar_csi2 *priv, unsigned int bpp,
> return -ENODEV;
>
> source = priv->remote;
> + remote_pad = &source->entity.pads[priv->remote_pad];
>
> - freq = v4l2_get_link_freq(source->ctrl_handler, bpp, 2 * lanes);
> + freq = v4l2_get_link_freq(remote_pad, bpp, 2 * lanes);
> if (freq < 0) {
> int ret = (int)freq;
>
--
Regards,
Laurent Pinchart
