On Mon, Sep 08, 2025 at 06:09:13PM +0000, Kriish Sharma wrote: > Replace the deprecated strncpy() with strscpy() for ib_name in > smc_pnet_add_ib(). The destination buffer should be NUL-terminated and > does not require any trailing NUL-padding. Since ib_name is a fixed-size > array, the two-argument form of strscpy() is sufficient and preferred. > > Signed-off-by: Kriish Sharma <kriish.sharma2006@xxxxxxxxx> > --- > net/smc/smc_pnet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c > index 76ad29e31d60..b90337f86e83 100644 > --- a/net/smc/smc_pnet.c > +++ b/net/smc/smc_pnet.c > @@ -450,7 +450,7 @@ static int smc_pnet_add_ib(struct smc_pnettable *pnettable, char *ib_name, > return -ENOMEM; > new_pe->type = SMC_PNET_IB; > memcpy(new_pe->pnet_name, pnet_name, SMC_MAX_PNETID_LEN); > - strncpy(new_pe->ib_name, ib_name, IB_DEVICE_NAME_MAX); > + strscpy(new_pe->ib_name, ib_name); It is worth to mention that caching ib_name is wrong as IB/core provides IB device rename functionality. Thanks > new_pe->ib_port = ib_port; > > new_ibdev = true; > -- > 2.34.1 > >
