Re: [PATCH] eth: mlx4: Fix IS_ERR() vs NULL check bug in mlx4_en_create_rx_ring

[Tariq Toukan <ttoukan.linux@xxxxxxxxx>]

On 06/08/2025 2:09, Jakub Kicinski wrote:
> On Tue,  5 Aug 2025 06:50:57 +0400 Miaoqian Lin wrote:
> >   	ring->pp = page_pool_create(&pp);
> > -	if (!ring->pp)
> > +	if (IS_ERR(ring->pp))
> >   		goto err_ring;
>
> Thanks for fixing! Looks we previously depended on err being initialized
> to -ENOMEM, but since we have an errno now, I think it'd be better to
> use it:
>
> 	if (IS_ERR(ring->pp)) {
> 		err = PTR_ERR(ring->pp);
> 		goto err_ring;
> 	}

+1