Hi Shawn, On Mon, Aug 26, 2024 at 05:38:34PM -0400, Frank Li wrote: > The mass production lx2160 rev2 use designware PCIe Controller. Old Rev1 > which use mobivel PCIe controller was not supported. Although uboot > fixup can change compatible string fsl,lx2160a-pcie to fsl,ls2088a-pcie > since 2019, it is quite confused and should correctly reflect hardware > status in dtb. Change freescale's board to use rev2's dtsi firstly. > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 2 +- > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 +- > arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > index 4d721197d837e..71d0d6745e44a 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts > @@ -6,7 +6,7 @@ > > /dts-v1/; > > -#include "fsl-lx2160a.dtsi" > +#include "fsl-lx2160a-rev2.dtsi" > > / { > model = "NXP Layerscape LX2160AQDS"; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > index 0c44b3cbef773..2373e1c371e8c 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > @@ -6,7 +6,7 @@ > > /dts-v1/; > > -#include "fsl-lx2160a.dtsi" > +#include "fsl-lx2160a-rev2.dtsi" > > / { > model = "NXP Layerscape LX2160ARDB"; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > index 9f5ff1ffe7d5e..7a595fddc0273 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > @@ -6,7 +6,7 @@ > > /dts-v1/; > > -#include "fsl-lx2160a.dtsi" > +#include "fsl-lx2160a-rev2.dtsi" > > / { > model = "NXP Layerscape LX2162AQDS"; > > -- > 2.34.1 > > Sorry for digging up an old thread, but I'm curious why you applied patch 2/3 but not this one? Currently, arch/arm64/boot/dts/freescale/fsl-lx2160a-rev2.dtsi has no user. Thread here. https://lore.kernel.org/lkml/20240826-2160r2-v1-0-106340d538d6@xxxxxxx/