On Wed, Aug 13, 2025 at 12:23:22PM +0800, hans.zhang@xxxxxxxxxxx wrote: > From: Manikandan K Pillai <mpillai@xxxxxxxxxxx> > > Split the Cadence PCIe controller EP functionality into common > ibrary functions and functions for legacy PCIe EP controller. s/ibrary/library/ > +++ b/drivers/pci/controller/cadence/pcie-cadence-ep-common.c > @@ -0,0 +1,252 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (c) 2017 Cadence > +// Cadence PCIe endpoint controller driver common > +// Author: Manikandan K Pillai <mpillai@xxxxxxxxxxx> This *looks* like mostly a code move from pcie-cadence-ep.c to pcie-cadence-ep-common.c. If that's the case, make this patch *only* a move (no code changes or whitespace changes as in cdns_pcie_ep_start()). And say in the commit log that you're only moving, not changing, the code. Also preserve the author from pcie-cadence-ep.c if that's the case. I do look a little sideways at the // comments since the pcie-cadence* files are basically the only users in drivers/pci/ (except for the ibmhp driver that is ancient and basically dead). Bjorn
