Re: [PATCH v7 02/13] PCI: cadence: Split PCIe controller header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 13, 2025 at 12:23:20PM +0800, hans.zhang@xxxxxxxxxxx wrote:
> From: Manikandan K Pillai <mpillai@xxxxxxxxxxx>
> 
> Split the Cadence PCIe header file by moving the Legacy(LGA)
> controller register definitions to a separate header file for
> support of next generation PCIe controller architecture.

s/Legacy(LGA)/Legacy (LGA)/

Similar for "HPA(High Performance architecture)" elsewhere.

> +++ b/drivers/pci/controller/cadence/pcie-cadence-lga-regs.h
> @@ -0,0 +1,228 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +// Copyright (c) 2017 Cadence
> +// Cadence PCIe controller driver.
> +// Author: Manikandan K Pillai <mpillai@xxxxxxxxxxx>

I'm not trying to be a killjoy, but the only author listed in
pcie-cadence.h is Cyrille Pitchen, and I don't think simply moving
these definitions to a separate file really counts as becoming the
author.  I would at least preserve Cyrille's authorship.

Bjorn




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux