No need to repeat "cadence" in the subject. Something like this would
be sufficient:
PCI: cadence: Add module support for platform controller driver
On Wed, Aug 13, 2025 at 12:23:19PM +0800, hans.zhang@xxxxxxxxxxx wrote:
> From: Manikandan K Pillai <mpillai@xxxxxxxxxxx>
>
> Add support for building PCI cadence platforms as a module.
>
> Signed-off-by: Manikandan K Pillai <mpillai@xxxxxxxxxxx>
> Signed-off-by: Hans Zhang <hans.zhang@xxxxxxxxxxx>
> +++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c
> @@ -178,3 +178,7 @@ static struct platform_driver cdns_plat_pcie_driver = {
> .shutdown = cdns_plat_pcie_shutdown,
> };
> builtin_platform_driver(cdns_plat_pcie_driver);
Do you need any change here, e.g., to module_platform_driver()? I'm
not an expert in the module machinery, so just a question.
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Cadence PCIe controller platform driver");
> +MODULE_AUTHOR("Manikandan K Pillai <mpillai@xxxxxxxxxxx>");
> diff --git a/drivers/pci/controller/cadence/pcie-cadence.c b/drivers/pci/controller/cadence/pcie-cadence.c
> index 70a19573440e..5603f214f4c7 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence.c
> @@ -279,6 +279,7 @@ const struct dev_pm_ops cdns_pcie_pm_ops = {
> NOIRQ_SYSTEM_SLEEP_PM_OPS(cdns_pcie_suspend_noirq,
> cdns_pcie_resume_noirq)
> };
> +EXPORT_SYMBOL_GPL(cdns_pcie_pm_ops);
>
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("Cadence PCIe controller driver");
> --
> 2.49.0
>
