On 8/20/25 6:56 AM, Danilo Krummrich wrote:
On Wed Aug 20, 2025 at 3:52 PM CEST, Alexandre Courbot wrote:
This is making use of `from_class_and_vendor`, which is modified in the
next patch, requiring to modify this part of the file again. How about
switching this patch with 3/3 so we only modify the nova-core code once?
I think that makes sense.
Sure.
I also wonder if we want to merge 1/3 and (the current) 3/3, since 1/3
alone leaves `from_class_and_vendor` into some intermediate state that
nobody will ever get a chance to use anyway, and one doesn't really make
sense without the other. WDYT?
Let's not merge them please, the intermediate state is not that bad, currently
we deal with raw integers for representing vendor IDs as well. So, patch 1 is an
improvement even by itself.
OK.
thanks,
--
John Hubbard
