Hi Bjorn,
Thanks for your review comments.
On Tue, 26 Aug 2025 at 21:55, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>
> In subject, remove "dwc: " to follow historical convention. (See
> "git log --oneline")
>
Ok I will keep it as per the git history.
> On Tue, Aug 26, 2025 at 05:12:40PM +0530, Anand Moon wrote:
> > Currently, the driver acquires clocks and prepare/enable/disable/unprepare
> > the clocks individually thereby making the driver complex to read.
> >
> > The driver can be simplified by using the clk_bulk*() APIs.
> >
> > Use:
> > - devm_clk_bulk_get_all() API to acquire all the clocks
> > - clk_bulk_prepare_enable() to prepare/enable clocks
> > - clk_bulk_disable_unprepare() APIs to disable/unprepare them in bulk
>
> I assume this means the order in which we prepare/enable and
> disable/unprepare will now depend on the order the clocks appear in
> the device tree instead of the order in the code? If so, please
> mention that here and verify that all upstream device trees have the
> correct order.
>
Following is the order in the device tree
clocks = <&crg HISTB_PCIE_AUX_CLK>,
<&crg HISTB_PCIE_PIPE_CLK>,
<&crg HISTB_PCIE_SYS_CLK>,
<&crg HISTB_PCIE_BUS_CLK>;
clock-names = "aux", "pipe", "sys", "bus";
Ok I will update this in the commit message.
Thanks
-Anand
