Am Montag, 25. August 2025, 10:28:38 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > Like many other Rockchip drivers, rockchip-dfi brings with it its own > HIWORD_UPDATE macro. This variant doesn't shift the value (and like the > others, doesn't do any checking). > > Remove it, and replace instances of it with hw_bitfield.h's > FIELD_PREP_WM16. Since FIELD_PREP_WM16 requires contiguous masks and > shifts the value for us, some reshuffling of definitions needs to > happen. > > This gives us better compile-time error checking, and in my opinion, > nicer code. > > Tested on an RK3568 ODROID-M1 board, and an RK3588 ROCK 5B board. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
