Re: [PATCH v3 02/20] mmc: dw_mmc-rockchip: switch to FIELD_PREP_WM16 macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, 25. August 2025, 10:28:22 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli:
> The era of hand-rolled HIWORD_UPDATE macros is over, at least for those
> drivers that use constant masks.
> 
> Switch to the new FIELD_PREP_WM16 macro in hw_bitfield.h, which has
> error checking. Instead of redefining the driver's HIWORD_UPDATE macro
> in this case, replace the two only instances of it with the new macro,
> as I could test that they result in an equivalent value.
> 
> Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx>

Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>

and going from $random-hex-value to GENMASK is a nice added benefit







[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux