> You shouldn't need to include ipmi_smi.h. If you do, that's a bug on my part. Thanks, you're right that it builds without ipmi_smi.h. I'll remove it in the next patch. > I don't see anything that will prevent multiple messages from being sent at one time. What happens if two things send a message at the same time here? That shouldn't happen since the messages are serialized by craye1k->lock. That lock is taken at the driver entry points: craye1k_get_attention_status() & craye1k_set_attention_status().
