On 25-08-25, 21:26, Krishna Chaitanya Chundru wrote: > looks like for compare_floor we need to iterate to the OPP table till > the OPP key is greater than the target key and return previous OPP. It depends on what kind of comparison we need to do. And this this is how it works for the _floor variants. But we don't always return the previous OPP. `compare` directly updates the `opp` and so it can be currently iterated one too. > In that case the updation of the key and dev_pm_opp_get() should be > outside as before. We need to remove this part of the patch. I think all we need to do here is check if an error is there or not, maybe I am misreading it. -- viresh
