On 8/26/2025 2:02 PM, Krzysztof Kozlowski wrote:
On 26/08/2025 10:27, Krzysztof Kozlowski wrote:
On 26/08/2025 07:18, Krishna Chaitanya Chundru wrote:
The qcom_pcie_parse_ports() function currently iterates over all available
child nodes of the PCIe controller's device tree node. This can lead to
attempts to parse unrelated nodes like OPP nodes, resulting in unnecessary
errors or misconfiguration.
Restrict the parsing logic to only consider child nodes named "pcie" or
"pci", which are the expected node names for PCIe ports.
Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@xxxxxxxxxxxxxxxx>
---
drivers/pci/controller/dwc/pcie-qcom.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 294babe1816e4d0c2b2343fe22d89af72afcd6cd..5dbdb69fbdd1b9b78a3ebba3cd50d78168f2d595 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1740,6 +1740,8 @@ static int qcom_pcie_parse_ports(struct qcom_pcie *pcie)
int ret = -ENOENT;
for_each_available_child_of_node_scoped(dev->of_node, of_port) {
+ if (!(of_node_name_eq(of_port, "pcie") || of_node_name_eq(of_port, "pci")))
Huh? Where is this ABI documented?
I see it actually might be documented, but you did not mention it at
all. I doubt you even checked.
Please reference exactly where is the ABI, so reviewing will be easier.
I still think though that it is wrong - we don't want device node names
to be the ABI if we already have compatibles and the children here
should have them, right?
I intended to check for device_type to be pci, my mistake I went with
the node name, I will update the patch with this logic
if (!of_node_is_type(np, "pci"))
continue
Thanks for reviewing it.
- Krishna Chaitanya.
Best regards,
Krzysztof
