On Tue, Aug 26, 2025 at 04:32:52PM GMT, Krishna Chaitanya Chundru wrote: > Describe PCIe controller and PHY. Also add required system resources like > regulators, clocks, interrupts and registers configuration for PCIe. > > The qcom_pcie_parse_ports() function currently iterates over all available > child nodes of the PCIe controller's device tree node. This includes > unrelated nodes such as OPP (Operating Performance Points) nodes, which do > not contain the expected 'reset' and 'phy' properties. As a result, parsing > fails and the driver falls back to the legacy method of parsing the > controller node directly. However, this fallback also fails when properties > are shifted to the root port, leading to probe failure. > > Fix this by restricting the parsing logic to only consider child nodes with > device_type = "pci", which is the expected and required property for PCIe > ports as defined in pci-bus-common.yaml. > > Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@xxxxxxxxxxxxxxxx> > --- > Changes in v3: > - Use device_type to find pci node or not instead of node name. > - Link to v2: https://lore.kernel.org/r/20250826-pakala-v2-0-74f1f60676c6@xxxxxxxxxxxxxxxx > > Changes in v2: > - Follow the x1e80100.dtsi pcie node description (Konrad). > - define phy & perst, wake in port node as per latest bindings. > - Add check in the driver to parse only pcie child nodes. > - Added acked by tag(Rob). > - Removed dtbinding and phy driver patches as they got applied. > - Link to v1: https://lore.kernel.org/r/20250809-pakala-v1-0-abf1c416dbaa@xxxxxxxxxxxxxxxx > > --- > Krishna Chaitanya Chundru (3): > dt-bindings: PCI: qcom,pcie-sm8550: Add SM8750 compatible > arm64: dts: qcom: sm8750: Add PCIe PHY and controller node > PCI: qcom: Restrict port parsing only to pci child nodes Applied patches 1 and 3, thanks! - Mani -- மணிவண்ணன் சதாசிவம்
