On Fri, Aug 22, 2025 at 05:55:44PM +0300, Ilpo Järvinen wrote: > pci-legacy.c under MIPS has a copy of pci_enable_resources() named as > pcibios_enable_resources(). Having own copy of same functionality could > lead to inconsistencies in behavior, especially now as > pci_enable_resources() and the bridge window resource flags behavior > are going to be altered by upcoming changes. > > The check for !r->start && r->end is already covered by the more > generic checks done in pci_enable_resources(). > > Call pci_enable_resources() from MIPS's pcibios_enable_device() and > remove pcibios_enable_resources(). > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- > arch/mips/pci/pci-legacy.c | 38 ++------------------------------------ > 1 file changed, 2 insertions(+), 36 deletions(-) Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]