Hi Kevin, On Thu, Aug 21, 2025 at 07:41:57AM -0700, Nicolin Chen wrote: > On Thu, Aug 21, 2025 at 08:07:01AM +0000, Tian, Kevin wrote: > > Usually the difference between func() and func_locked() is only about > > whether the caller holds a lock. If they mean to return different > > domains, may need better naming (though I don't have a good option > > now)... > > Yea, naming is tricky here :) > > Perhaps it could follow a different pattern: > iommu_dev_get_domain_for_driver(struct device *dev); > > With a simple note highlighting to be used by IOMMU drivers in the > iommu callback functions like attach_dev. I am keeping this "_locked" naming in v4, as there are only two places calling this new helper and only one of them is a driver. Please check v4 and see if you still prefer a different name. Thanks Nic
