On Tue, Aug 19, 2025 at 07:52:30PM GMT, hans.zhang@xxxxxxxxxxx wrote: > From: Manikandan K Pillai <mpillai@xxxxxxxxxxx> > > Move the Cadence PCIe controller RP common functions into a separate > file. The common library functions are split from legacy PCIe RP controller > functions to a separate file. > > Signed-off-by: Manikandan K Pillai <mpillai@xxxxxxxxxxx> > Co-developed-by: Hans Zhang <hans.zhang@xxxxxxxxxxx> > Signed-off-by: Hans Zhang <hans.zhang@xxxxxxxxxxx> > --- > drivers/pci/controller/cadence/Makefile | 2 +- > .../cadence/pcie-cadence-host-common.c | 179 ++++++++++++++++++ > .../cadence/pcie-cadence-host-common.h | 24 +++ > .../controller/cadence/pcie-cadence-host.c | 156 +-------------- > 4 files changed, 205 insertions(+), 156 deletions(-) > create mode 100644 drivers/pci/controller/cadence/pcie-cadence-host-common.c > create mode 100644 drivers/pci/controller/cadence/pcie-cadence-host-common.h > > diff --git a/drivers/pci/controller/cadence/Makefile b/drivers/pci/controller/cadence/Makefile > index 80c1c4be7e80..e45f72388bbb 100644 > --- a/drivers/pci/controller/cadence/Makefile > +++ b/drivers/pci/controller/cadence/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_PCIE_CADENCE) += pcie-cadence.o > -obj-$(CONFIG_PCIE_CADENCE_HOST) += pcie-cadence-host.o > +obj-$(CONFIG_PCIE_CADENCE_HOST) += pcie-cadence-host-common.o pcie-cadence-host.o > obj-$(CONFIG_PCIE_CADENCE_EP) += pcie-cadence-ep-common.o pcie-cadence-ep.o > obj-$(CONFIG_PCIE_CADENCE_PLAT) += pcie-cadence-plat.o > obj-$(CONFIG_PCI_J721E) += pci-j721e.o > diff --git a/drivers/pci/controller/cadence/pcie-cadence-host-common.c b/drivers/pci/controller/cadence/pcie-cadence-host-common.c > new file mode 100644 > index 000000000000..d34f8c7c49f0 > --- /dev/null > +++ b/drivers/pci/controller/cadence/pcie-cadence-host-common.c > @@ -0,0 +1,179 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (c) 2017 Cadence > +// Cadence PCIe host controller driver. This should be changed to 'Cadence PCIe host controller library'. For completeness, you should add the 'Author' tag also. - Mani -- மணிவண்ணன் சதாசிவம்