On Wed, 03 Sep 2025, Marcos Del Sol Vives wrote: > El 03/09/2025 a las 9:21, Lee Jones escribió: > >> vortex_dx_sb are "struct vortex_southbridge" type, not raw MFD API data. > > > > I like your style, but nope! > > > > vortex_southbridge contains MFD data and shouldn't exist anyway. > > I'm not sure if I follow. > > You're suggesting not using driver_data at all and using a big "if" instead, > matching manually myself on the correct cells to register against the PCI > device ID, instead of relying on PCI matching giving me already the cells > structure inside driver_data? Yes. > That seems to increase code size and be more error prone for no reason. It may make sense for your use-case, but believe me, I've seen some crazy implementations of this. I found it's easier just to have a no cross contamination of early init APSs rule and call it a day. -- Lee Jones [李琼斯]
