El 03/09/2025 a las 9:21, Lee Jones escribió:
>>>> +static const struct mfd_cell vortex_dx_sb_cells[] = {
>>>> + {
>>>> + .name = "vortex-gpio",
>>>> + .resources = vortex_dx_gpio_resources,
>>>> + .num_resources = ARRAY_SIZE(vortex_dx_gpio_resources),
>>>> + },
>>>> +};
>>>
>>> It's not an MFD until you have more than one device.
>>
>> Same as above.
>
> It will not be accepted with only a single device (SFD?).
>
I've been working on making all the changes, except this one.
If you prefer, I can either implement the watchdog now, add it on this
patch series and thus make it a proper MFD (at the cost of delaying
even further the GPIO inclusion), or keep the struct mfd_cell array
as a single-element array and implement the watchdog later on another
merge request, using that very same array.
I am however not okay with wasting my time rewriting that to bypass
the MFD API for this, so I can waste even more time later
implementing again the MFD API, just because linguistically
one (right now) is technically not "multi".
That seems very unreasonable, specially when it wouldn't be a first
since at least these other devices are also using MFD with a single
device:
- 88pm800
- 88pm805
- at91-usart
- stw481x
- vx855
- wm8400
- zynqmp (last changed in 2024, so certainly not legacy!)
And probably others since I did not look too deep into it.
Greetings,
Marcos
