On Mon, Sep 08, 2025 at 09:09:08AM +0530, Manivannan Sadhasivam wrote: > On Wed, Sep 03, 2025 at 06:14:41PM GMT, Siddharth Vadapalli wrote: > > Hello, > > > > This series enables support for the 'pci-keystone.c' driver to be built > > as a loadable module. The motivation for the series is that PCIe is not > > a necessity for booting Linux due to which the 'pci-keystone.c' driver > > does not need to be built-in. > > > > There are concerns from the irqchip maintainers that unloading an irqchip > controller is a bad idea. We had a lot of previous discussions on this topic. Ok, I wasn't aware of this. Thank you for pointing this out. > > But I would certainly welcome the idea of building a controller driver as a > module (tristate) and prevent unloading it during runtime (by keeping it as > builtin_platform_driver). I will update the series to retain 'builtin_platform_driver' while enabling tristate support. Since the intent of the series is primarily to convert the driver to support being built as a loadable module, and unloading it is only a secondary requirement which is optional, I agree with your suggestion. > > > Series is based on linux-next tagged next-20250903. > > > > No need to base your patches on top of linux-next. Either do it on top of -rc1 > or pci/next. I will keep this in mind when I post the v2 series. Thank you for your feedback. Regards, Siddharth.
