Re: [PATCH v11 06/23] CXL/AER: Introduce rch_aer.c into AER driver for handling CXL RCH errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9/10/25 10:01 AM, Bowman, Terry wrote:
> 
> 
> On 8/29/2025 3:39 AM, Lukas Wunner wrote:
>> On Thu, Aug 28, 2025 at 01:53:35PM -0700, Dave Jiang wrote:
>>> On 8/26/25 6:35 PM, Terry Bowman wrote:
>>>>  drivers/cxl/Kconfig        |   9 +++-
>>>>  drivers/cxl/core/ras.c     |   3 ++
>>>>  drivers/pci/pci.h          |  20 +++++++
>>>>  drivers/pci/pcie/Makefile  |   1 +
>>>>  drivers/pci/pcie/aer.c     | 108 +++----------------------------------
>>>>  drivers/pci/pcie/rch_aer.c |  99 ++++++++++++++++++++++++++++++++++
>>> I wonder if this should be cxl_rch_aer.c to be clear that it's cxl
>>> related code.
>> I'd prefer an "aer_" prefix at the beginning of filenames,
>> but maybe that's just me...
>>
>> Thanks,
>>
>> Lukas
> You guys let me know what to rename it to. I'm fine with either 
> change: cxl_rch_aer.c or aer_cxl_rch.c.

I'll defer to Lukas since this is in drivers/pci.

DJ

> 
> We also have the VH analog of this file currently named pcie/cxl_aer.c. 
> This is introduced in patch 17, CXL/AER: 
> 'Introduce cxl_aer.c into AER driver for forwarding CXL errors'.
> 
> We may need to make similar change to the VH file name as well to 
> be consistent.
> 
> Regards,
> Terry





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux