On Wed, Aug 20, 2025 at 04:52:00PM +0800, Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> Therefore, remove the useless call to dev_err_probe(), and just
> return the value instead.
Seems sort of weird to avoid dev_err_probe(-ENOMEM) because we have
internal knowledge that dev_err_probe() does nothing in that case.
It leads to patterns where the first few things in a .probe() function
return -ENOMEM directly and later things use dev_err_probe(), and
there's no obvious reason for the difference.
But it's very common, so I guess it's OK with me to follow the common
pattern even though it's a bit strange.
> Signed-off-by: Xichao Zhao <zhao.xichao@xxxxxxxx>
> ---
> drivers/pci/controller/plda/pcie-plda-host.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/plda/pcie-plda-host.c b/drivers/pci/controller/plda/pcie-plda-host.c
> index 8e2db2e5b64b..3c2f68383010 100644
> --- a/drivers/pci/controller/plda/pcie-plda-host.c
> +++ b/drivers/pci/controller/plda/pcie-plda-host.c
> @@ -599,8 +599,7 @@ int plda_pcie_host_init(struct plda_pcie_rp *port, struct pci_ops *ops,
>
> bridge = devm_pci_alloc_host_bridge(dev, 0);
> if (!bridge)
> - return dev_err_probe(dev, -ENOMEM,
> - "failed to alloc bridge\n");
> + return -ENOMEM;
>
> if (port->host_ops && port->host_ops->host_init) {
> ret = port->host_ops->host_init(port);
> --
> 2.34.1
>
