On Wed, Aug 13, 2025 at 05:12:57PM +0800, Hans Zhang wrote: > > > On 2025/8/13 16:31, Rob Herring (Arm) wrote: > > EXTERNAL EMAIL > > > > On Wed, 13 Aug 2025 12:23:26 +0800, hans.zhang@xxxxxxxxxxx wrote: > > > From: Hans Zhang <hans.zhang@xxxxxxxxxxx> > > > > > > Document the bindings for CIX Sky1 PCIe Controller configured in > > > root complex mode with five root port. > > > > > > Supports 4 INTx, MSI and MSI-x interrupts from the ARM GICv3 controller. > > > > > > Signed-off-by: Hans Zhang <hans.zhang@xxxxxxxxxxx> > > > --- > > > .../bindings/pci/cix,sky1-pcie-host.yaml | 79 +++++++++++++++++++ > > > 1 file changed, 79 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dtb: /: 'compatible' is a required property > > from schema $id: http://devicetree.org/schemas/root-node.yaml# > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dtb: /: 'model' is a required property > > from schema $id: http://devicetree.org/schemas/root-node.yaml# > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250813042331.1258272-9-hans.zhang@xxxxxxxxxxx > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > > > Dear Rob, > > I'm very sorry. No errors were detected on my PC. I'll check my local > environment and fix this issue in the next version. > > If I have done anything wrong, please remind me. > > > > hans@hans:~/code/kernel_org/linux$ export CROSS_COMPILE=/home/hans/cix/bringup_master/tools/gcc/arm-gnu-toolchain-12.3.rel1-x86_64-aarch64-none-linux-gnu/arm-gnu-toolchain-12.3.rel1-x86_64-aarch64-none-linux-gnu/bin/aarch64-none-linux-gnu- > hans@hans:~/code/kernel_org/linux$ export ARCH=arm64 > hans@hans:~/code/kernel_org/linux$ make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml > SCHEMA Documentation/devicetree/bindings/processed-schema.json > CHKDT ./Documentation/devicetree/bindings > LINT ./Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dts > DTC [C] > Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dtb > hans@hans:~/code/kernel_org/linux$ make W=1 dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml DT_SCHEMA_FILES limits testing to only the matching pattern. Ultimately, you have to test without it. Rob
