On Sun, Aug 10, 2025 at 09:32:15PM -0300, Daniel Almeida wrote: > Manipulating IRQ flags (i.e.: IRQF_*) will soon be necessary, specially to > register IRQ handlers through bindings::request_irq(). > > Add a kernel::irq::Flags for that purpose. > > Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> > Tested-by: Joel Fernandes <joelagnelf@xxxxxxxxxx> > Tested-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx> > Signed-off-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx> > --- > rust/kernel/irq.rs | 6 +++ > rust/kernel/irq/flags.rs | 124 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 130 insertions(+) > > diff --git a/rust/kernel/irq.rs b/rust/kernel/irq.rs > index fae7b15effc80c936d6bffbd5b4150000d6c2898..d6306415f561f94a05b1c059eaa937b0b585471d 100644 > --- a/rust/kernel/irq.rs > +++ b/rust/kernel/irq.rs > @@ -9,3 +9,9 @@ > //! drivers to register a handler for a given IRQ line. > //! > //! C header: [`include/linux/device.h`](srctree/include/linux/interrupt.h) > + > +/// Flags to be used when registering IRQ handlers. > +pub mod flags; > + > +#[doc(inline)] > +pub use flags::Flags; Minor nit, I would drop the pub on `mod flags`. Then you don't need doc(inline). Alice