On Fri, 01 Aug 2025 14:34:37 +0100,
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> There is a typo so we accidentally return positive EINVAL instead of
> negative -EINVAL. Add the missing '-' character.
>
> Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/pci/controller/pci-xgene-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
> index 0a37a3f1809c..654639bccd10 100644
> --- a/drivers/pci/controller/pci-xgene-msi.c
> +++ b/drivers/pci/controller/pci-xgene-msi.c
> @@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
> msi_val = xgene_msi_int_read(xgene_msi, i);
> if (msi_val) {
> dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
> - return EINVAL;
> + return -EINVAL;
> }
>
> irq = platform_get_irq(pdev, i);
Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
M.
--
Without deviation from the norm, progress is not possible.
