Re: [PATCH v2] rust: pci: Use explicit types in FFI callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue Jul 29, 2025 at 12:52 PM CEST, Miguel Ojeda wrote:
> On Tue, Jul 29, 2025 at 12:30 PM herculoxz <abhinav.ogl@xxxxxxxxx> wrote:
>>
>> and improves ABI
>> correctness when interfacing with C code.
>
> I think this still sounds like it is fixing an ABI issue -- I would
> probably just remove that second sentence.

I agree, the types exported via prelude are the ones from kernel::ffi.

> (But no need for a v3 -- I think it can be fixed on apply unless
> Danilo wants it).

Yeah, I can fix it up when applying the patch.

I also think the subject from v1, i.e. "use c_* types via kernel prelude", was
better. This one is a bit misleading, the types in the FFI callbacks are already
explicit.

Unless I hear otherwise, I will also revert the subject to the one of v1 when I
apply the patch.

Thanks,
Danilo





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux