On Tue, Jul 29, 2025 at 09:52:30AM +0200, Christoph Hellwig wrote: > On Thu, Jul 24, 2025 at 11:13:21AM +0300, Leon Romanovsky wrote: > > On Thu, Jul 24, 2025 at 10:03:13AM +0200, Christoph Hellwig wrote: > > > On Wed, Jul 23, 2025 at 04:00:06PM +0300, Leon Romanovsky wrote: > > > > From: Leon Romanovsky <leonro@xxxxxxxxxx> > > > > > > > > Export the pci_p2pdma_map_type() function to allow external modules > > > > and subsystems to determine the appropriate mapping type for P2PDMA > > > > transfers between a provider and target device. > > > > > > External modules have no business doing this. > > > > VFIO PCI code is built as module. There is no way to access PCI p2p code > > without exporting functions in it. > > We never ever export anything for "external" modules, and you really > should know that. It is just a wrong word in commit message. I clearly need it for vfio-pci module and nothing more. "Never attribute to malice that which is adequately explained by stupidity." - Hanlon's razor. Thanks > >
