Re: [PATCH] PCI: mvebu: Use devm_add_action_or_reset()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 25 Jul 2025 04:57:05 +0100
Salah Triki <salah.triki@xxxxxxxxx> wrote:

> On Thu, Jul 24, 2025 at 11:42:17AM -0500, Bjorn Helgaas wrote:
> > On Sat, Jul 19, 2025 at 05:34:40AM +0100, Salah Triki wrote:
> > 
> >   ret = devm_add_action_or_reset(dev, clk_put, port->clk)
> >   
> The second argument of devm_add_action_or_reset() is of type void (*)(void *)
> and the argument of clk_put() is of type struct clk *, so I think a cast is
> needed:
> 
> ret = devm_add_action_or_reset(dev, (void (*)(void *)) clk_put, port->clk)

Can you use devm_get_clk_from_child() here?  If not add a similar variant.


> 
> Best regards,
> Salah Triki
> 





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux