Bowman, Terry wrote: > > > On 7/23/2025 7:01 PM, dan.j.williams@xxxxxxxxx wrote: > > Terry Bowman wrote: > >> The CXL AER error handling logic currently resides in the AER driver file, > >> drivers/pci/pcie/aer.c. CXL specific changes are conditionally compiled > >> using #ifdefs. > >> > >> Improve the AER driver maintainability by separating the CXL specific logic > >> from the AER driver's core functionality and removing the #ifdefs. > >> Introduce drivers/pci/pcie/cxl_aer.c and move the CXL AER logic into the > >> new file. > >> > >> Update the makefile to conditionally compile the CXL file using the > >> existing CONFIG_PCIEAER_CXL Kconfig. > >> > >> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > > [..] > >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > >> index e2d71b6fdd84..31b3935bf189 100644 > >> --- a/include/linux/pci_ids.h > >> +++ b/include/linux/pci_ids.h > >> @@ -12,6 +12,8 @@ > >> > >> /* Device classes and subclasses */ > >> > >> +#define PCI_CLASS_CODE_MASK 0xFFFF00 > > Per other comments do not add this updated in the same patch as the > > move. > > > > When / if you submit it separately it likely also belongs next to > > PCI_CLASS_REVISION in include/uapi/linux/pci_regs.h defined with > > __GENMASK(23, 8). > > include/uapi/linux/pci_regs.h appears to use all values without using GENMASK(). > Just adding as a note. I'm making the change. pci_regs.h is in include/uapi/. Historically that meant that it was unable to use GENMASK() from include/linux/. That changed "recently" (compared to the age of pci_regs.h) with commit: 3c7a8e190bc5 uapi: introduce uapi-friendly macros for GENMASK
