Re: [PATCH v3] vmcoreinfo: Track and log recoverable hardware errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2025-07-23 at 21:00 +0200, Borislav Petkov wrote:
> On Wed, Jul 23, 2025 at 08:36:52AM -0700, Breno Leitao wrote:
> > Basically there are two approaches, from what I understand:
> > 
> > 	1) mark do_machine_check() as noinstr
> 
> do_machine_check is already noinstr. I think you mean mark
> hwerr_log_error_type() noinstr.
> 
> And yes, you can mark it. hwerr_log_error_type() is not that fascinating
> to allow instrumentation for it.

This option doesn't seem to be able to work because IIRC
hwerr_log_error_type() calls ktime_get_real_seconds() which is not
'noinstr'.

> 
> > 	2) Move hwerr_log_error_type() earlier inside the
> > 	instrumentation_begin() area.
> 
> Or you can do that - that looks like less of an effort btw.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux