On Wed, Jul 23, 2025 at 10:21:41AM +0800, Baolu Lu wrote: > On 7/23/25 05:58, Nicolin Chen wrote: > > > return 0; > > > > > > guard(mutex)(&group->mutex); > > I recall Baolu mentioned that Joerg might not like the guard style > > so I am keeping mutex_lock/unlock(). > > You may be misremembering or mixing something up. I didn't see Joerg > express that opinion. :-) > > My understanding is that cleanup.h could be used in new or refactored > code, but people don't like converting existing lock/unlock mechanisms > for no real benefit. Ah, thanks for clarifying. Let's do the guard() way then :) Nicolin
