On Wed, 16 Jul 2025, Bjorn Helgaas wrote: > Maybe we should just accept that broken hardware exists and add quirks > to limit link speed or tell the user to buy a working device. I was actually wondering if we should define a new kind of DECLARE_PCI_FIXUP_<LINKUP> which allows vendors/users to implement an appropriate link recovery for their circumstances. In one of our storage appliance product-lines we actually have a kind of quirk of our own which is implemented to work-around some older Gen3 PCIe switches that had some official erratum. Honestly we would like to not have to carry these patches, but there wasn't an obvious way to upstream them. We could probably re-work them to fit into a kind of new fixup. My belief is that we try to not bend the generic handling in the kernel around specific device issues because once implemented we are essentially enabling devices in the future to have such bugs/interactions. In the case of this ASMedia/Pericom switch combination I'm told from others internally that its possibly that changing the link presets or other settings may resolve the ltssm looping issue, but it would probably require ASMedia/Pericom to look into. Cheers! - Matt
