Re: [PATCH] pci/controller: Use dev_fwnode()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 15, 2025 at 01:49:17PM -0500, Bjorn Helgaas wrote:
> On Wed, Jun 11, 2025 at 12:43:44PM +0200, Jiri Slaby (SUSE) wrote:
> > irq_domain_create_simple() takes fwnode as the first argument. It can be
> > extracted from the struct device using dev_fwnode() helper instead of
> > using of_node with of_fwnode_handle().
> > 
> > So use the dev_fwnode() helper.
> > 
> > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Cc: linux-pci@xxxxxxxxxxxxxxx
> > ---
> >  drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 5 ++---
> >  drivers/pci/controller/pcie-mediatek-gen3.c          | 3 +--
> 
> I think the pcie-mediatek-gen3.c part of this is no longer relevant
> after Nam's series [1].

fwnode is still needed after my patch. As part of
struct irq_domain_info info = { ... }

You could squash this one into my patch. I personally would leave it be.
But fine to me either way.

> This pcie-mediatek-gen3.c was the only thing on the
> pci/controller/mediatek-gen3 branch, so I'm going to drop that for now.
> 
> The pcie-mobiveil-host.c part is still queued on
> pci/controller/mobiveil for v6.17.
> 
> [1] https://patch.msgid.link/bfbd2e375269071b69e1aa85e629ee4b7c99518f.1750858083.git.namcao@xxxxxxxxxxxxx

Best regards,
Nam




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux