On Mon, Jul 14, 2025 at 5:13 PM Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx> wrote: > > Hi, > > > > >>> > >>> (2) It is guaranteed that the device pointer is valid because (1) guarantees > >>> it's even bound and because Devres<RegistrationInner> itself has a > >>> reference count. > >> > >> Yeah but I would find it much more natural (and also useful in other > >> circumstances) if `Devres<T>` would give you access to `Device` (at > >> least the `Normal` type state). > > > > If we use container_of!() instead or just pass the address of Self (i.e. > > Registration) to request_irq() instead, > > > Boqun, Benno, are you ok with passing the address of Registration<T> as the cookie? > > Recall that this was a change requested in v4, so I am checking whether we are > all on the same page before going back to that. > > See [0], i.e.: > [0] https://lore.kernel.org/all/aFq3P_4XgP0dUrAS@xxxxxxxx/ After discussing this, Daniel and I agreed that I will implement the change adding a Device<Bound> argument to the callback. I will be sending a patch adding it separately as a follow-up to Daniel's work. Alice
