On Mon, Jul 14, 2025 at 11:31:05PM +0530, Manivannan Sadhasivam wrote:
> It allows us to group all the settings that need to be done when a PCI
> device is attached to the bus in a single place.
This commit message should be amended so that it makes sense on its own
(e.g. without Subject).
> @@ -1616,8 +1616,6 @@ static irqreturn_t qcom_pcie_global_irq_thread(int irq, void *data)
> pci_lock_rescan_remove();
> pci_rescan_bus(pp->bridge->bus);
> pci_unlock_rescan_remove();
> -
> - qcom_pcie_icc_opp_update(pcie);
> } else {
> dev_WARN_ONCE(dev, 1, "Received unknown event. INT_STATUS: 0x%08x\n",
> status);
> @@ -1765,6 +1763,7 @@ static int pcie_qcom_notify(struct notifier_block *nb, unsigned long action,
> switch (action) {
> case BUS_NOTIFY_BIND_DRIVER:
> qcom_pcie_enable_aspm(pdev);
> + qcom_pcie_icc_opp_update(pcie);
I guess you should also drop the now redundant
qcom_pcie_icc_opp_update() call from probe()?
> break;
> }
Johan
