----- Original Message ----- > From: "Krishna Kumar" <krishnak@xxxxxxxxxxxxx> > To: "Bjorn Helgaas" <helgaas@xxxxxxxxxx>, "Timothy Pearson" <tpearson@xxxxxxxxxxxxxxxxxxxxx> > Cc: "linuxppc-dev" <linuxppc-dev@xxxxxxxxxxxxxxxx>, "linux-kernel" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-pci" > <linux-pci@xxxxxxxxxxxxxxx>, "Madhavan Srinivasan" <maddy@xxxxxxxxxxxxx>, "Michael Ellerman" <mpe@xxxxxxxxxxxxxx>, > "christophe leroy" <christophe.leroy@xxxxxxxxxx>, "Naveen N Rao" <naveen@xxxxxxxxxx>, "Bjorn Helgaas" > <bhelgaas@xxxxxxxxxx>, "Shawn Anastasio" <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, "Lukas Wunner" <lukas@xxxxxxxxx> > Sent: Monday, July 7, 2025 3:01:00 AM > Subject: Re: [PATCH v2 6/6] pci/hotplug/pnv_php: Enable third attention indicator > Thanks all for the review and Thanks a bunch to Timothy for fixing the PE Freeze > issue. The hotplug issues are like you fix N issue and N+1 th issue will come > with new HW. > > We had a meeting of around 1.5 -2.0 hr with demo, code review and log review and > we decided to let these fixes go ahead. I am consolidating what we discussed - > > > 1. Let these fixes go ahead as it solves wider and much needed customer issue > and its urgently needed for time being. We have verified in live demo that > nothing is broken from legacy flow and > > PE/PHB freeze, race condition, hung, oops etc has been solved correctly. > Basically it fixes below issues - > > root-port(phb) -> switch(having4 port)--> 2 nvme devices > > 1st case - only removal of EP-nvme device (surprise hotplug disables msi at root > port), soft removal may work > 2nd case - If we remove switch itself (surprise hotplug disable msi at root > port) . Just a quick follow up to see if anything else is needed from my end before this merge can occur? Thanks!
