On Tue, Jul 08, 2025 at 04:49:57PM +0200, Jerome Brunet wrote: > The id associated with MW2 configfs entry is wrong. > Trying to use MW2 will overwrite the existing BAR setup associated with > MW1. :%s/id/ID need new line between two paragraph. Frank > > Just put the correct id for MW2 to fix the situation > > Fixes: 4eacb24f6fa3 ("PCI: endpoint: pci-epf-vntb: Allow BAR assignment via configfs") > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > --- > drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c > index 41b297b16574558e7ab99fb047204ac29f6f3391..ac83a6dc6116be190f955adc46a30d065d3724fd 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > @@ -993,8 +993,8 @@ EPF_NTB_BAR_R(db_bar, BAR_DB) > EPF_NTB_BAR_W(db_bar, BAR_DB) > EPF_NTB_BAR_R(mw1_bar, BAR_MW1) > EPF_NTB_BAR_W(mw1_bar, BAR_MW1) > -EPF_NTB_BAR_R(mw2_bar, BAR_MW1) > -EPF_NTB_BAR_W(mw2_bar, BAR_MW1) > +EPF_NTB_BAR_R(mw2_bar, BAR_MW2) > +EPF_NTB_BAR_W(mw2_bar, BAR_MW2) > EPF_NTB_BAR_R(mw3_bar, BAR_MW3) > EPF_NTB_BAR_W(mw3_bar, BAR_MW3) > EPF_NTB_BAR_R(mw4_bar, BAR_MW4) > > --- > base-commit: 38be2ac97d2df0c248b57e19b9a35b30d1388852 > change-id: 20250708-vntb-mw-fixup-bc30a3e29061 > > Best regards, > -- > Jerome >