On Tue Jul 8, 2025 at 8:04 AM CEST, Alistair Popple wrote:
> diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
> index 7f640ba8f19c..f41fd9facb90 100644
> --- a/rust/kernel/pci.rs
> +++ b/rust/kernel/pci.rs
> @@ -393,6 +393,42 @@ pub fn device_id(&self) -> u16 {
> unsafe { (*self.as_raw()).device }
> }
>
> + /// Returns the PCI revision ID.
> + pub fn revision_id(&self) -> u8 {
We should add a compiler hint for those methods to be inlined.
> + // SAFETY: `self.as_raw` is a valid pointer to a `struct pci_dev`.
Let's refer to the type invariant for the validity of self.as_raw().
> + unsafe { (*self.as_raw()).revision }
> + }
Both is also true for the existing methods vendor_id() and device_id(). Can you
please fix them up in a separate patch as well?
Also, please add a brief note in the commit message where those will be used
(even though I obviously know). :)
