On Wed, Jul 02, 2025 at 11:21:20AM -0500, Bowman, Terry wrote: > > > On 6/27/2025 5:24 AM, Jonathan Cameron wrote: > > On Thu, 26 Jun 2025 17:42:40 -0500 > > Terry Bowman <terry.bowman@xxxxxxx> wrote: > > > >> CXL error handling will soon be moved from the AER driver into the CXL > >> driver. This requires a notification mechanism for the AER driver to share > >> the AER interrupt with the CXL driver. The notification will be used > >> as an indication for the CXL drivers to handle and log the CXL RAS errors. > >> > >> First, introduce cxl/core/native_ras.c to contain changes for the CXL > >> driver's RAS native handling. This as an alternative to dropping the > >> changes into existing cxl/core/ras.c file with purpose to avoid #ifdefs. > >> Introduce CXL Kconfig CXL_NATIVE_RAS, dependent on PCIEAER_CXL, to > >> conditionally compile the new file. > >> > >> Add a kfifo work queue to be used by the AER driver and CXL driver. The AER > >> driver will be the sole kfifo producer adding work and the cxl_core will be > >> the sole kfifo consumer removing work. Add the boilerplate kfifo support. > >> > >> Add CXL work queue handler registration functions in the AER driver. Export > >> the functions allowing CXL driver to access. Implement registration > >> functions for the CXL driver to assign or clear the work handler function. > >> > >> Introduce 'struct cxl_proto_err_info' to serve as the kfifo work data. This > >> will contain the erring device's PCI SBDF details used to rediscover the > >> device after the CXL driver dequeues the kfifo work. The device rediscovery > >> will be introduced along with the CXL handling in future patches. > >> > >> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > > Hi Terry, > > > > Whilst it obviously makes patch preparation a bit more time consuming > > for series like this with many patches it can be useful to add a brief > > change log to the individual patches as well as the cover letter. > > That helps reviewers figure out where they need to look again. > > > > A few trivial things inline. > > > > With those fixed up > > Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx> > > > > Jonathan > > Hi Jonathan, > > Do you have an example you can point me to with a change log in the > individual patch? I want to make certain I change correctly. > https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Just put a: --- v2: white space changes or whatever. regards, dan carpenter
